-
-
Notifications
You must be signed in to change notification settings - Fork 224
Fix expert mode start button loading state #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Buena |
|
All buttons need to show the loading indicator (or at least be disabled) because you shouldn't be able to start expert mode with root while you're starting it with shizuku for example. What do you think? Thanks for contributing though :) |
|
I initially thought about that too, but if possible, for example, when booting via Root, it would hide the startup components of Shizuku and KeyMapperAdb. I'm just making a simple contribution with this PR; I'll also be contributing to fixing ExpertMode in the future, but it involves many changes and requires time. Thank you :D |
I would probably go with disabling the other buttons and having the one you tapped showing the indicator. |
|
Yeah, i agree jambl3r. I'll implement this. @binhmod what other fixes do you want to make for expert mode? Before working on any PRs, first comment in the corresponding issue (or make a new one) so we know you will start working on something |
|
I want to add a handler for Expert mode at runtime to check if it's actually running (if there's an error, it should ping the UI, and optimize it using a binder or broadcast). |
Previously, the loading state was shared across all start options
(Root, Shizuku, ADB), causing multiple start buttons to display a
loading indicator simultaneously.
This PR scopes the loading state to the selected start method by
checking
startingMethod, ensuring that only the active start optionshows a loading indicator. The loading state is also cleared correctly
once the system bridge connects.
Translated from Vietnamese to English using Google Translate. Thank you.