Skip to content

Conversation

@binhmod
Copy link

@binhmod binhmod commented Jan 2, 2026

Previously, the loading state was shared across all start options
(Root, Shizuku, ADB), causing multiple start buttons to display a
loading indicator simultaneously.

This PR scopes the loading state to the selected start method by
checking startingMethod, ensuring that only the active start option
shows a loading indicator. The loading state is also cleared correctly
once the system bridge connects.

Translated from Vietnamese to English using Google Translate. Thank you.

@juangarcia15894-a11y
Copy link

Buena

@sds100 sds100 added this to the 4.0 milestone Jan 4, 2026
@sds100
Copy link
Collaborator

sds100 commented Jan 4, 2026

All buttons need to show the loading indicator (or at least be disabled) because you shouldn't be able to start expert mode with root while you're starting it with shizuku for example.

What do you think? Thanks for contributing though :)

@binhmod
Copy link
Author

binhmod commented Jan 5, 2026

I initially thought about that too, but if possible, for example, when booting via Root, it would hide the startup components of Shizuku and KeyMapperAdb.

I'm just making a simple contribution with this PR; I'll also be contributing to fixing ExpertMode in the future, but it involves many changes and requires time. Thank you :D

@jambl3r
Copy link
Collaborator

jambl3r commented Jan 5, 2026

All buttons need to show the loading indicator (or at least be disabled) because you shouldn't be able to start expert mode with root while you're starting it with shizuku for example.

What do you think? Thanks for contributing though :)

I would probably go with disabling the other buttons and having the one you tapped showing the indicator.

@sds100
Copy link
Collaborator

sds100 commented Jan 10, 2026

Yeah, i agree jambl3r. I'll implement this. @binhmod what other fixes do you want to make for expert mode? Before working on any PRs, first comment in the corresponding issue (or make a new one) so we know you will start working on something

@binhmod
Copy link
Author

binhmod commented Jan 11, 2026

I want to add a handler for Expert mode at runtime to check if it's actually running (if there's an error, it should ping the UI, and optimize it using a binder or broadcast).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants